remove unused code#7961
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7961 +/- ##
==========================================
Coverage ? 67.63%
==========================================
Files ? 467
Lines ? 65191
Branches ? 10008
==========================================
Hits ? 44094
Misses ? 18272
Partials ? 2825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CI报告基于以下代码生成(30分钟更新一次): 1 任务总览存在 1 个 Required 失败任务,需处理后方可合并。
2 任务状态汇总2.1 Required任务 : 9/10 通过
2.2 可选任务 — 28/32 通过
3 失败详情(仅 required)Run FastDeploy Unit Tests and Coverage / run_tests_with_coverage — 测试失败(置信度: 中)Run FastDeploy Unit Tests and Coverage / run_tests_with_coverage
失败用例:
根因详情: 关键日志: 修复建议:
修复建议摘要: 与PR无关,请 rerun;如反复失败查IPC共享内存 关联变更: PR 仅修改 |
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-05-31 16:29:31
📋 Review 摘要
PR 概述:移除 mask_s 函数中未使用的模板参数 partition_kv、num_frags_y 和 IS_SYSTEM,消除对应的死代码分支。
变更范围:custom_ops/gpu_ops/append_attn/
影响面 Tag:[OP]
问题
未发现阻塞性问题。
📝 PR 规范检查
PR 标题和描述均不合规:标题缺少 Tag 且无实际描述;描述各段落为空。
标题建议(可直接复制):
[OP] Remove unused IS_SYSTEM template parameter from mask_s
PR 描述建议(点击展开,可直接复制)
## Motivation
Remove dead code in append attention kernel. The `IS_SYSTEM` template parameter in `mask_s` function was never instantiated with `true` by any caller, making the corresponding branch unreachable.
## Modifications
- Removed `IS_SYSTEM` template parameter (defaulted to `false`) from `mask_s` in `append_attention_func.cuh`
- Eliminated the `if constexpr (IS_SYSTEM)` dead code branch, keeping only the active `!IS_SYSTEM` logic
- Cleaned up redundant parentheses in `mask_check_iteration` calculation in `multiquery_attention_c16_impl.cuh`
## Usage or Command
N/A
## Accuracy Tests
N/A (pure refactoring, no behavioral change)
## Checklist
- [x] Add at least a tag in the PR title.
- Tag list: [`[FDConfig]`,`[APIServer]`,`[Engine]`, `[Scheduler]`, `[PD Disaggregation]`, `[Executor]`, `[Graph Optimization]`, `[Speculative Decoding]`, `[RL]`, `[Models]`, `[Quantization]`, `[Loader]`, `[OP]`, `[KVCache]`, `[DataProcessor]`, `[BugFix]`, `[Docs]`, `[CI]`, `[Optimization]`, `[Feature]`, `[Benchmark]`, `[Others]`, `[XPU]`, `[HPU]`, `[GCU]`, `[DCU]`, `[Iluvatar]`, `[Metax]`]
- You can add new tags based on the PR content, but the semantics must be clear.
- [x] Format your code, run `pre-commit` before commit.
- [x] Add unit tests. Please write the reason in this PR if no unit tests.
- [ ] Provide accuracy results.
- [ ] If the current PR is submitting to the `release` branch, make sure the PR has been submitted to the `develop` branch, then cherry-pick it to the `release` branch with the `[Cherry-Pick]` PR tag.总体评价
本 PR 是纯重构变更,移除了从未被实例化为 true 的 IS_SYSTEM 模板分支和两个未使用的模板参数(partition_kv、num_frags_y),逻辑等价且安全。建议补充 PR 标题 Tag 和描述以符合项目规范。
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.