Skip to content

Conversation

@qwes5s5
Copy link
Collaborator

@qwes5s5 qwes5s5 commented Dec 25, 2025

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

It has been observed that trace_id and span_id are currently injected across all logs via LoggingInstrumentor().instrument() in fastdeploy/metrics/trace_util.py. In many scenarios, this information is not utilized and reduces log readability. Therefore, a toggle is required to control the scope of this trace information injection.

Modifications

  • Add environment variable GLOBAL_LOGGING_INSTRUMENT, disabled by default.
  • When GLOBAL_LOGGING_INSTRUMENT is disabled, trace_id and span_id will only be injected into logs within trace.log.
  • When GLOBAL_LOGGING_INSTRUMENT is enabled, use the original LoggingInstrumentor().instrument() to perform global injection.
  • Rename the log file from trace_logger.log to trace.log.

Usage or Command

  • export GLOBAL_LOGGING_INSTRUMENT=1: Enable global log injection.
  • export GLOBAL_LOGGING_INSTRUMENT=0: Disable global injection; trace information will only be injected into trace.log.

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2025

CLA assistant check
All committers have signed the CLA.

@paddle-bot
Copy link

paddle-bot bot commented Dec 25, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/2.4@f50988d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/metrics/trace_util.py 14.81% 23 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release/2.4    #5765   +/-   ##
==============================================
  Coverage               ?   59.03%           
==============================================
  Files                  ?      328           
  Lines                  ?    40755           
  Branches               ?     6208           
==============================================
  Hits                   ?    24060           
  Misses                 ?    14815           
  Partials               ?     1880           
Flag Coverage Δ
GPU 59.03% <14.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants