refactor: remove uuid dependency and simplify database operations in …#9
Merged
Conversation
…GitHub integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/google/uuiddependency (go.mod/go.sum) across the entire plugin — ID generation is now handled by PostgreSQL.branches.go,integration.go,pull_requests.go, andwebhook.go; INSERT statements no longer include anidcolumn.db.Exectodb.QuerywithRETURNING id(orRETURNING id, created_at) to retrieve the database-generated primary key.linkPRToTaskandhandlePREvent: removes the pre-SELECT that checked whether a PR was already cached (replaced by the upsert'sRETURNINGresult).github_task_branchesandgithub_task_pr_linksinserts also drop their explicitidcolumns.Test plan
repo_id.pr_idcomes fromRETURNING.go.modno longer listsgithub.com/google/uuid.