Add constructor reference support for attributes#155
Open
RemcoSmitsDev wants to merge 1 commit into
Open
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, while I was trying out this LSP again, I noticed that find all references for a constructor didn't work in combination with attributes. So this PR fixes this by adding a new
ClassRefContextoption calledAttribute, this allows us to do some additional checks for getting all the right references in the case of class attributes.Here is a video of how works now, vs how it was before (it didn't find any references at all) because the class used in my example the symfony
Groupclass attribute is never normally instantiated usingnew Group.Note for the reviewer: A part of this change was assistet with AI because I don't know the code that good.
So let me know if you want me to make any changes!
Screen.Recording.2026-06-13.at.20.24.52.mov