SciML extension: add linters - #505
Open
dilpath wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 75.12% 75.33% +0.20%
==========================================
Files 64 64
Lines 7161 7354 +193
Branches 1267 1327 +60
==========================================
+ Hits 5380 5540 +160
- Misses 1291 1309 +18
- Partials 490 505 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
approved these changes
Aug 3, 2026
Comment on lines
+493
to
+496
| posterior = any( | ||
| p.prior_distribution is not None for p in problem.parameters | ||
| ) | ||
| if posterior: |
Member
There was a problem hiding this comment.
Suggested change
| posterior = any( | |
| p.prior_distribution is not None for p in problem.parameters | |
| ) | |
| if posterior: | |
| if problem.has_map_objective: |
?
(This only checks for priors on estimated parameters, though.)
Comment on lines
+48
to
+52
| "CheckNeuralNetworkModel", | ||
| "CheckHybridizationTable", | ||
| "CheckSciMLConditionTable", | ||
| "CheckArrayDataFiles", | ||
| "CheckSciMLParameterTable", |
Member
There was a problem hiding this comment.
Do we need to re-export them here? If so, I would prefer a SciML prefix in all of those; if not, let's remove them from here.
Comment on lines
+1215
to
+1216
| except ImportError: | ||
| sciml_validation_tasks = default_validation_tasks |
Member
There was a problem hiding this comment.
Can we move sciml_validation_tasks to .extensions.sciml_lint or .extensions.sciml?
BSnelling
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated based on PEtab-dev/petab_sciml#69