Repository navigation
fix: keep Clippy green on the Rust 1.99 stable toolchain - #34
Merged
Merged
Conversation
The workspace Clippy job lints with the floating `stable` toolchain, on top of `clippy::all` + `clippy::pedantic`, with `-D warnings`. The Rust 1.99 stable release therefore breaks the job without any source change: - `AtomicU64::fetch_update` is deprecated in favour of `try_update`, which is still unstable before Rust 1.95 while the workspace MSRV is 1.88. The MSRV-compatible calls keep `fetch_update` behind a localized `#[allow(deprecated)]` with the reason recorded next to it. - `clippy::double_must_use` now fires on `#[async_trait]` traits, because async-trait 0.1.91 stamps `#[must_use]` on the generated boxed futures, and on the `CommunityClasspath::artifacts` accessor, whose `impl ExactSizeIterator` return type is already `#[must_use]`. That accessor still needs an attribute for `clippy::must_use_candidate` on Rust 1.88, so it now carries an explicit reason, which both toolchains accept. - The new pedantic `clippy::assert_is_empty` lint fires on the empty assertions in the test suites. Only lint compliance changed; assertions keep their original meaning.
openai0229
force-pushed
the
fix/stable-clippy-drift
branch
from
October 8, 2026 05:24
f58a145 to
aa15697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace Clippy job lints with the floating
stabletoolchain, on top ofclippy::all+clippy::pedantic, with-D warnings. The Rust 1.99 stable release therefore fails that job on unchanged sources and blocks thev0.0.1release pipeline (Release CIreusesci.ymlfrom the tag).Three new diagnostics are addressed with lint-only changes:
AtomicU64::fetch_updateis deprecated in favour oftry_update, which is still unstable before Rust 1.95 while the workspace MSRV is 1.88. The MSRV-compatible calls keepfetch_updatebehind a localized#[allow(deprecated)]that records the reason.clippy::double_must_usenow fires on#[async_trait]traits, because async-trait 0.1.91 stamps#[must_use]on the generated boxed futures, and on one hand-written#[must_use]accessor whoseimpl ExactSizeIteratorreturn type is already#[must_use]; that redundant attribute is removed.clippy::assert_is_emptylint fires on empty assertions in the test suites; the assertions keep their original meaning and now report the length or an explicit message on failure.Validation completed locally against the same steps as the
RustandRust 1.88jobs:cargo clippy --workspace --exclude chat2db-desktop --all-targets --all-features --locked -- -D warningson 1.99.0 passed.cargo check --workspace --exclude chat2db-desktop --all-targets --all-features --lockedon 1.88.0 (MSRV) passed.cargo fmt --all --checkpassed.cargo test --workspace --exclude chat2db-desktop --locked: 824 passed, 10 ignored. Ran from a short temporary worktree because an existing macOS Unix-socket test exceedsSUN_LENfrom the longer feature-worktree path.cargo test -p chat2db-java-bridge --features test-fixture --test supervisor --locked: 53 passed.The two edited Java/H2 integration test files were compiled here; their real database/H2 execution is covered by repository CI.
chat2db-desktopkeeps its threefetch_updatecalls because its Clippy job is pinned to Rust 1.88.0 and does not lint them.Review entry points:
crates/chat2db-java-bridge/src/supervisor/community.rs,crates/chat2db-core/src/native_driver.rs, and thefetch_updatesites incrates/chat2db-core/src/{operation.rs,agent/hub.rs}.AI assistance: implementation, review, and verification performed with Codex.