Repository navigation
fix: preserve annotated tag validation in package workflow - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
v0.0.1tag run failed before packaging because actions/checkout rewrites the checked-out tag ref to the tagged commit. The validation step therefore saw a commit object and rejected a correctly annotated tag.Restore the remote tag object in the validation step before checking its type. This keeps the annotated-tag gate and verifies the tagged commit remains reachable from
origin/main.Validation:
actionlint .github/workflows/package.ymlgit diff --checkThe failed run was
37721948027; no Release was created and the existing tag is not published. After this PR merges, the failed tag will be recreated on the newmaincommit and the release workflow rerun.AI assistance: implementation and verification performed with Codex.