Added support for SSE BSAs #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Alright, tests passing. There aren't any tests for SSE BSAs yet - I'll add those once we have a test BSA in testing-plugins. |
Author
|
Added SSE plugins and BSA to |
Owner
|
Now that I've merged the testing-plugins PR, can you extend the existing tests to also check the SSE BSAs? |
Author
|
Sure, I'll get right on that! 😄 |
Author
|
NOTE: I didn't add LZ4 to libbsa, so I'm fairly certain decompression will not be working on my PR. We'll see once I add the tests. ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was tested in my .NET wrapper version of SSE, but should be tested again somehow as well. I presume some things will need to be changed/adjusted, so just let me know what I should do to get things 👌.
^_^