-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add .slnx solution file #18628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .slnx solution file #18628
Conversation
|
I had to delete the .sln because there was a build error if there is more than 1 solution file. |
Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
|
I already did this, but didn't push it, but it's good to use the new cleaner solution file |
| <Project Path="test/OrchardCore.Tests.Themes/Examples.Themes.AssyAttrib.Charlie/Examples.Themes.AssyAttrib.Charlie.csproj" /> | ||
| </Folder> | ||
| <Properties Name="Performance"> | ||
| <Property Name="HasPerformanceSessions" Value="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was in the existing sln.
Here are the explanations I get asking about HasPerformanceSessions:
In a .NET / Visual Studio solution file (.sln), the HasPerformanceSessions = true entry appears when Visual Studio has stored Performance Profiler session data for that solution.
It usually looks like this inside the .sln file:
GlobalSection(Performance) = preSolution
HasPerformanceSessions = true
EndGlobalSection
Why it appears?
Visual Studio automatically adds this when you run the Performance Profiler (via Debug → Performance Profiler or Analyze → Performance Profiler).
It persists even after closing the profiler unless you remove the session from the Performance Explorer.
How to remove it?
From Visual Studio UI
Open Performance Explorer:
Analyze → Windows → Performance Explorer
If you see any profiling sessions listed, right-click → Remove.
Save the solution — the HasPerformanceSessions entry should disappear.
Manual removal
Close Visual Studio.
Open the .sln file in a text editor.
Delete the GlobalSection(Performance) block containing HasPerformanceSessions.
Save and reopen the solution.
Prevent it from reappearing
✅ Tip: This setting is harmless — it doesn’t affect build or runtime behavior. It’s only metadata for Visual Studio’s profiling tools.
|
@agriffard could you answer my previous question? Then we can merge |
|
Let's merge this .. |
Use new simpler xml format for solution file.
Comparison:
Current .sln: 150ko
Added .slnx: 28ko