chore: add python import sorting #20453
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff ( https://docs.astral.sh/ruff ) is a modern code checking tool that combines many formatting and style/correctness linting tools and is really fast. It has a lot of options for things that have previously been flake8 plugins or separate tools, and it's configured in pyproject.toml instead of a separate file. It also has a lot of options for things we've wanted forever but haven't found a good tool for yet - like import sorting! Its formatting codestyle philosophy is very similar to black - not a lot of options, which is good - and so is its formatting output... but its formatting output is not _identical_ to black's, and so there is a big old diff here that is 99% automatic and 1% "that type: ignore or noqa is in the wrong place now".
Giant diff, no code changes.
Add ruff isort integration!
ddcc4
approved these changes
Dec 24, 2025
Collaborator
ddcc4
left a comment
ddcc4
left a comment
There was a problem hiding this comment.
Wow, this is a big diff. I'm glad we don't have an active release branch that will create merge conflicts with this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ruff's https://docs.astral.sh/ruff/settings/#lintisort isort integration we can sort our python imports! Finally!
The first commit has the settings for this, the rest of the commits just add them.
Draft for circular import reasons.