fix(protocol-designer): getMatchingTipLiquidSpecs() don't crash if tiprackDef is null #20447
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20447 +/- ##
=======================================
Coverage 56.09% 56.09%
=======================================
Files 3678 3678
Lines 309732 309731 -1
Branches 45827 45825 -2
=======================================
+ Hits 173741 173744 +3
+ Misses 135748 135744 -4
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
koji
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In
getMatchingTipLiquidSpecs(), we were crashing while trying to compose the error message ... lolI think the crash could be happening for 2 reasons: either
tiprackDefis null, or it could be one of those nasty custom tip racks whose definition doesn't have a.parameters(which has bitten us before).This change will make us stop crashing and get a bit better diagnostic information.
Test Plan and Hands on Testing
Run CI tests.
Risk assessment
Low.