Skip to content

Conversation

@rclarke0
Copy link
Contributor

Overview

Prevent users from adding the magnetic block beside the flex stacker in deck configuration by expanding the component size.

Test Plan and Hands on Testing

smoke tested in protocol designer and in the app

module.in.app.mov
prevent.adding.module.in.slot.3.mov

Review requests

Risk assessment

low

Closes EXEC-2203

@rclarke0 rclarke0 requested a review from a team as a code owner December 22, 2025 21:52
@rclarke0 rclarke0 requested review from TamarZanzouri and ncdiehl11 and removed request for a team December 22, 2025 21:52
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (8859804) to head (f345eb7).

Files with missing lines Patch % Lines
.../hardware-sim/DeckConfigurator/FlexStackerItem.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20438      +/-   ##
==========================================
+ Coverage   56.09%   56.26%   +0.17%     
==========================================
  Files        3672     3671       -1     
  Lines      309719   309712       -7     
  Branches    45927    45914      -13     
==========================================
+ Hits       173737   174265     +528     
+ Misses     135739   135199     -540     
- Partials      243      248       +5     
Flag Coverage Δ
app 46.43% <0.00%> (+0.21%) ⬆️
opentrons-ai-client 2.79% <0.00%> (-0.28%) ⬇️
protocol-designer 19.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../hardware-sim/DeckConfigurator/FlexStackerItem.tsx 3.50% <0.00%> (ø)

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the logic that calculates what modules are allowed next to flex stacker than changing the width. I think that getModuleOptions will give you a head start. we can look at this together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants