Skip to content

Conversation

@rclarke0
Copy link
Contributor

Overview

Labware definitions without a stackLimit are not currently able to be moved to a stacker hopper. This PR checks if the stacker is in the stack list, and sets isAboveStackLimit to false. This fixes the error if a labware does not have a defined stackLimit in its definition.

Test Plan and Hands on Testing

Tested on protocol in ticket EXEC-2206

Review requests

Will this mess up other labware moves?

Risk assessment

medium

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.14%. Comparing base (21573f5) to head (fef8998).
⚠️ Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
step-generation/src/utils/misc.ts 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20435      +/-   ##
==========================================
+ Coverage   56.10%   56.14%   +0.03%     
==========================================
  Files        3669     3669              
  Lines      309400   309605     +205     
  Branches    45921    45952      +31     
==========================================
+ Hits       173586   173823     +237     
+ Misses     135571   135539      -32     
  Partials      243      243              
Flag Coverage Δ
protocol-designer 19.49% <0.00%> (+0.04%) ⬆️
step-generation 5.74% <93.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
step-generation/src/utils/misc.ts 63.02% <93.75%> (+0.14%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants