feat(protocol-designer): add the moduleStateUpdate to 8_8_0 migration #20418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #20418 +/- ##
==========================================
- Coverage 56.06% 56.06% -0.01%
==========================================
Files 3663 3664 +1
Lines 308848 308887 +39
Branches 45926 45926
==========================================
+ Hits 173168 173170 +2
- Misses 135435 135472 +37
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
approved these changes
Dec 18, 2025
| ...acc, | ||
| [id]: { | ||
| ...form, | ||
| moduleStateUpdate: {}, |
Collaborator
There was a problem hiding this comment.
So we're committed to this now? :) :)
ddcc4
reviewed
Dec 18, 2025
| // @ts-expect-error | ||
| '8.7.0': migrateFileEightSeven, | ||
| // @ts-expect-error | ||
| '8.8.0': migrateFileEightEight, |
Collaborator
There was a problem hiding this comment.
Hehe, were we going to rename this to migrateTwoThousandSixDotOne for the new PD versioning scheme?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added the new location update key to the migration, it is empty so its a small migration
Test Plan and Hands on Testing
test importing an old protocol and see that it imports correctly
Changelog
create migration file and plug it in
Risk assessment
low