feat(hardware-testing): upgrade evaporation calculations #20392
Conversation
This reverts commit 52c3877.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20392 +/- ##
==========================================
+ Coverage 56.74% 56.78% +0.04%
==========================================
Files 3649 3657 +8
Lines 303774 304603 +829
Branches 42724 43035 +311
==========================================
+ Hits 172383 172978 +595
- Misses 131177 131411 +234
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
inline comments. more broadly it seems like touch_blank=True and touch_blank=False don't actually do anything different, can we get rid of the csv changes?
| fixture_settings.pipette._get_last_location_by_api_version().point.z, # type: ignore [union-attr] | ||
| ) | ||
| if fixture_settings.touch_blank: | ||
| blank_move_to_height = liquid_height - fixture_settings.submerge_depth |
There was a problem hiding this comment.
these are the same, right? can get rid of the if?
There was a problem hiding this comment.
Dang app copies of protocols being different then the original files strikes again
| except Exception as e: | ||
| print_error(f"error during run {e}") | ||
| print_error(f"Captured traceback:\n{traceback.format_exc()}") | ||
| error = e |
There was a problem hiding this comment.
| error = e | |
| raise |
?
There was a problem hiding this comment.
Because we need to hit the finally block before raising to properly close out the output file and shut down the scale
There was a problem hiding this comment.
the finally will still run in that case:
opentrons [ add-sentry-electron-apps](MERGING) [ ][🐍 ]
❯ cat test.py
try:
raise Exception("oh no")
except Exception:
print("caught an exception!")
raise
finally:
print("finally")
❯ python test.py
caught an exception!
finally
Traceback (most recent call last):
File "/Users/sethfoster/dev/opentrons/test.py", line 2, in <module>
raise Exception("oh no")
Exception: oh no
There was a problem hiding this comment.
the finally runs before the exception gets re-dispatched
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Looks good once we fix that reraise thing
Overview
Add a new version of evaporation calculation to the gravimetric script.