feat(reports): configure bar chart display limits - #500
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe report options schema now supports a configurable bar-chart display limit. Report settings validate and dispatch values from 1 through 500. The bar chart uses the configured limit and defaults to 10 when no bar option is available. ChangesBar chart display limit
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature · Severity of issue fixed: Medium Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ReportSettings
participant ReportSlice
participant BarChart
ReportSettings->>ReportSlice: dispatch changeOptions with displayLimit
ReportSlice->>BarChart: provide updated report options
BarChart->>BarChart: use options.displayLimit for bar series
Merge Risk: ⚪ Minimal · up to The configurable bar-chart row limit is validated, saved through report options, and applied by the chart while preserving the default behavior for reports without a configured value. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bar reports gain a “Rows to display” setting (1–500). The value is stored in the existing report options, so saved dashboard and shared reports retain it. Reports without the option keep their existing display behavior; query limits are unchanged.
Closes #397.
Validation: eight option-validation tests pass, the frontend typecheck passes after Prisma generation, and
git diff --checkpasses. Existing create/update/share report paths already persist and return options, so no database migration is required. Full-file Biome reports existing filename, inferred-array and bar-interaction warnings in the touched components; this change is limited to the new setting.Summary by CodeRabbit
New Features
Bug Fixes
Tests