-
Notifications
You must be signed in to change notification settings - Fork 477
feat(embed): auto-resize share iframes (#224) #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grootbro
wants to merge
4
commits into
Openpanel-dev:main
Choose a base branch
from
grootbro:feat/iframe-auto-height-224
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b1d9836
feat(embed): auto-resize share iframes and keep modals in view
grootbro e4b8988
fix(embed): address CodeRabbit review on iframe auto-height
grootbro 5ef6a8f
fix(embed): guard measureEmbedContentHeight without a DOM
grootbro e3328e7
test(embed): exercise default measureEmbedContentHeight path
grootbro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /** | ||
| * OpenPanel share embed host — auto-sizes iframes marked with | ||
| * data-openpanel-embed and answers viewport queries so in-frame dialogs | ||
| * can center on the visible slice (parent scroll ≠ iframe mid-point). | ||
| * | ||
| * Usage: | ||
| * <iframe data-openpanel-embed src="https://…/share/overview/…" …></iframe> | ||
| * <script async src="https://…/openpanel-embed.js"></script> | ||
| */ | ||
| (() => { | ||
| const SOURCE = 'openpanel-embed'; | ||
| const SELECTOR = 'iframe[data-openpanel-embed]'; | ||
|
|
||
| function iframes() { | ||
| return Array.from(document.querySelectorAll(SELECTOR)); | ||
| } | ||
|
|
||
| function viewportFor(iframe) { | ||
| const rect = iframe.getBoundingClientRect(); | ||
| const visibleTop = Math.min(rect.height, Math.max(0, -rect.top)); | ||
| const visibleBottom = Math.min(rect.height, window.innerHeight - rect.top); | ||
| const visibleHeight = Math.max(0, visibleBottom - visibleTop); | ||
| return { visibleTop, visibleHeight }; | ||
| } | ||
|
|
||
| function replyViewport(iframe, source) { | ||
| const { visibleTop, visibleHeight } = viewportFor(iframe); | ||
| source.postMessage( | ||
| { source: SOURCE, type: 'viewport', visibleTop, visibleHeight }, | ||
| '*', | ||
| ); | ||
| } | ||
|
|
||
| function onMessage(event) { | ||
| const data = event.data; | ||
| if (!data || data.source !== SOURCE) { | ||
| return; | ||
| } | ||
|
|
||
| const iframe = iframes().find((el) => el.contentWindow === event.source); | ||
| if (!iframe) { | ||
| return; | ||
| } | ||
|
|
||
| if (data.type === 'resize' && typeof data.height === 'number') { | ||
| const next = Math.max(0, Math.ceil(data.height)); | ||
| if (String(iframe.height) !== String(next)) { | ||
| iframe.style.height = `${next}px`; | ||
| iframe.setAttribute('height', String(next)); | ||
| } | ||
| if (event.source) { | ||
| event.source.postMessage( | ||
| { source: SOURCE, type: 'resize-ack', height: next }, | ||
| '*', | ||
| ); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| if (data.type === 'request-viewport' && event.source) { | ||
| replyViewport(iframe, event.source); | ||
| } | ||
| } | ||
|
|
||
| function broadcastViewport() { | ||
| for (const iframe of iframes()) { | ||
| if (iframe.contentWindow) { | ||
| replyViewport(iframe, iframe.contentWindow); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function pingIframes() { | ||
| for (const iframe of iframes()) { | ||
| if (iframe.contentWindow) { | ||
| iframe.contentWindow.postMessage( | ||
| { source: SOURCE, type: 'request-resize' }, | ||
| '*', | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| window.addEventListener('message', onMessage); | ||
| window.addEventListener('scroll', broadcastViewport, { passive: true }); | ||
| window.addEventListener('resize', broadcastViewport); | ||
|
|
||
| function init() { | ||
| for (const iframe of iframes()) { | ||
| iframe.setAttribute('scrolling', 'no'); | ||
| if (!iframe.style.width) { | ||
| iframe.style.width = '100%'; | ||
| } | ||
| if (!iframe.style.border) { | ||
| iframe.style.border = '0'; | ||
| } | ||
| iframe.addEventListener('load', () => { | ||
| if (iframe.contentWindow) { | ||
| iframe.contentWindow.postMessage( | ||
| { source: SOURCE, type: 'request-resize' }, | ||
| '*', | ||
| ); | ||
| } | ||
| }); | ||
| } | ||
| pingIframes(); | ||
| } | ||
|
|
||
| if (document.readyState === 'loading') { | ||
| document.addEventListener('DOMContentLoaded', init); | ||
| } else { | ||
| init(); | ||
| } | ||
| })(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { afterEach, describe, expect, it, vi } from 'vitest'; | ||
| import { measureEmbedContentHeight } from './use-embed-viewport'; | ||
|
|
||
| describe('measureEmbedContentHeight', () => { | ||
| afterEach(() => { | ||
| vi.unstubAllGlobals(); | ||
| }); | ||
|
|
||
| it('returns 0 without reading HTMLElement when document is undefined', () => { | ||
| vi.stubGlobal('document', undefined); | ||
| vi.stubGlobal('HTMLElement', undefined); | ||
|
|
||
| expect(measureEmbedContentHeight()).toBe(0); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.