Repository navigation
fix(lock): ignore advertisements with an unknown lock status - #363
Merged
Merged
Conversation
A Lock Ultra on firmware 3.1 reports lock status values 11, 13, 14 and 15, which pySwitchbot's LockStatus does not define (SwitchBotAPI-BLE #54, pySwitchbot #595). lockStateFromStatus mapped every unknown value to "locked", so such an advertisement could show an unlocked door as locked. As in pySwitchbot PR #596, an advertisement with an unknown status is now ignored entirely, so the last known state stands: parseLockAdvertisement returns null and the scanner drops the advertisement. lockStateFromStatus returns undefined for unknown values, and isKnownLockStatus is exported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A Lock Ultra on firmware 3.1 reports lock status values 11, 13, 14 and 15. pySwitchbot's
LockStatusonly defines 0–7. This was reported in SwitchBotAPI-BLE#54 and pySwitchbot#595.In 6.1.0,
lockStateFromStatusmapped every unknown value tolocked, so one of these advertisements could show an unlocked door as locked.Fix
This follows pySwitchbot's open fix, pySwitchbot#596: an update with an unknown status is ignored, so the last known state stands.
parseLockAdvertisementreturnsnullfor an unknown status, which is distinct fromundefinedfor missing or short data. The scanner drops that advertisement, so it never replaces the device's last good data.lockStateFromStatusreturnsundefinedfor unknown values.isKnownLockStatusis exported.Tests
518 tests pass. Build and lint pass.
No breaking changes. Patch release (6.1.1).
Generated by Claude Code