fix: vocal mouth animation

[HardyNLee]

介绍

修复语音驱动的口型动画, 多播几次就不动的问题
(用 Live2d 能看得明显一点)

[gemini-code-assist]

Summary of Changes

Hello @HardyNLee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决一个关键的动画渲染问题，即语音驱动的口型动画在重复播放音频时会意外停止。通过优化音频上下文源的连接逻辑，确保每次播放都能正确地将音频流连接到分析器，从而提供稳定且流畅的口型动画体验。

Highlights

• 修复语音口型动画中断问题: 解决了语音驱动的口型动画在多次播放后停止工作的问题，特别是在 Live2d 场景下更为明显。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/webgal/src/Core/gameScripts/vocal/index.ts
  • 修改了 playVocal 函数中创建和连接 MediaElementSource 的逻辑。
  • 现在，如果 audioContextWrapper.source 为空，或者其关联的 mediaElement 与当前的 vocalControl 不匹配，则会重新创建音频源。
  • 在重新创建音频源之前，会显式断开旧的音频源连接，以避免资源泄露和不正确的音频流处理。
  • 为 audioContextWrapper.analyser 的连接添加了非空断言，以明确其预期状态。

Activity

• 目前没有评论或审查活动。

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

本次 PR 修复了语音驱动口型动画在多次播放后失效的问题。通过在播放语音时检查 MediaElementAudioSourceNode 是否与当前的 <audio> 元素关联，并在需要时重新创建和连接音频源，有效地解决了该问题。代码逻辑清晰，改动正确。我只提出了一个关于代码风格的小建议，以提高代码的可读性和健壮性。

[gemini-code-assist]

为了代码更清晰并避免使用非空断言 !，建议使用在函数前面已定义的 analyser 常量。这样可以利用 TypeScript 的类型推断，使代码更安全、更易读。

Suggested change

	audioContextWrapper.source.connect(audioContextWrapper.analyser!);
	audioContextWrapper.source.connect(analyser);