fix: voice volume #843

[MakinoharaShoko]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @MakinoharaShoko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with voice volume by enhancing the clarity of its calculation and ensuring that volume adjustments are consistently applied in response to changes in the vocal playback state. This change aims to provide a more reliable and accurate audio experience for voice elements.

Highlights

• Vocal Volume Calculation Refactoring: The calculation for vocalVol has been refactored into an intermediate vocalBaseVol variable, improving readability without altering the final volume output.
• useEffect Dependency Update: The useEffect hook responsible for setting the vocal element's volume now includes stageStore.playVocal in its dependency array. This ensures that the volume is correctly applied whenever the vocal playback state changes, addressing potential issues where volume might not update as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[cloudflare-workers-and-pages]

Deploying webgal-dev with    Cloudflare Pages

Latest commit:	e0ab2e4
Status:	✅  Deploy successful!
Preview URL:	https://878bbc1b.webgal-dev.pages.dev
Branch Preview URL:	https://fix-say-volume.webgal-dev.pages.dev

View logs

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where voice volume was not being applied when a new vocal track started. The change to the useEffect dependency array is the key part of this fix. The refactoring of the volume calculation also improves readability. I have added one suggestion to make the code even clearer by replacing a magic number with a more explicit calculation.

[gemini-code-assist]

For better readability and to avoid magic numbers, consider using division by 100 to convert percentage values to decimals instead of multiplying by 0.01. This makes the code's intent clearer.

Suggested change

	const vocalBaseVol = mainVol * 0.01 * userDataState.optionData.vocalVolume * 0.01;
	const vocalVol = vocalBaseVol * stageStore.vocalVolume * 0.01;
	const vocalBaseVol = (mainVol / 100) * (userDataState.optionData.vocalVolume / 100);
	const vocalVol = vocalBaseVol * (stageStore.vocalVolume / 100);

[HardyNLee]

测试似乎没有问题