fix(webgal): map global to globalThis in browser builds - #1025
Open
modenicheng wants to merge 1 commit into
Open
fix(webgal): map global to globalThis in browser builds#1025modenicheng wants to merge 1 commit into
modenicheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map the browser bundle's
globalidentifier toglobalThisso expression evaluation works in browser builds.Problem
angular-expressions@1.4.3accesses Node'sglobalduringcompile():When WebGAL runs in a browser bundle,
globalis undefined. This makes expression evaluation fail with:The failure affects script expressions such as
setVar:morale=morale+1and conditional evaluation used by-when. In the current error handling, those failures can silently turn into an empty variable value or a false condition.Fix
Configure Vite to replace
globalwith the browser-standardglobalThisin the generated bundle. This keeps the fix scoped to the browser build and avoids changing WebGAL's expression semantics.Validation
git diff --checkpasses.This is separate from #1005, which addresses expression evaluation semantics and variable extraction rather than the browser
globalcompatibility failure.