spec: PIPELINE-1 — resolve-lang-once, timeout defaults, match-phase liveness, reserved-name stamping suppression#109
Draft
JarbasAl wants to merge 2 commits into
Draft
spec: PIPELINE-1 — resolve-lang-once, timeout defaults, match-phase liveness, reserved-name stamping suppression#109JarbasAl wants to merge 2 commits into
JarbasAl wants to merge 2 commits into
Conversation
…own-key relaxation, deterministic reply source Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…imeout defaults, liveness, stamping suppression - Orchestrator resolves utterance language once per utterance when the entry topic carries no authoritative lang; plugins refine, never re-derive (§4, §9.1). - Match-phase timeout: RECOMMENDED 10 s default; applied bound MUST cover stage-internal collection ceilings (§4.4). - Context decay aligned with OVOS-CONTEXT-1 §4: post-match decrement after every match round, fresh entries exempt; §5.1 promotion citations (§6.1). - Orchestrator MUST keep servicing bus subscriptions while a match call is in flight (§6.5). - active_handlers stamping suppression keyed on the reserved intent_name, never the producing pipeline_id (§7.1, §7.3). - SESSION-1 registry citations corrected to §2.2; timeless wording. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal-purity refinement of OVOS-PIPELINE-1.
Changes
ovos.utterance.handlecarries no authoritativelang, the orchestrator MUST resolve the utterance language once from OVOS-SESSION-1 §3.2 evidence and pass the resolved tag to every plugin'smatchcall. Plugins MAY refine the tag but MUST NOT re-derive it independently — per-plugin resolution lets the same utterance match in different languages at different stages.Match.langstays the plugin's declaration.turns_remainingdecrement moves outside the matched branch, running after the match round whether or not any intent matched, with freshly written entries exempt — exactly the OVOS-CONTEXT-1 §4/§4.1 model. Promotion citations corrected to CONTEXT-1 §5.1.matchcall is in flight; a bus loop that blocks on the synchronous return deadlocks every bus-round-trip match strategy.session.active_handlerspush suppression MUST key on the Match'sintent_nameappearing in the §7.3 reserved-name registry, never on the producingpipeline_id— stated identically at both sites.CHANGELOG entry appended under the spec's current class. Version field unchanged: per VERSIONING.md it is a V1/V2 compatibility class, and these refinements do not change class.
🤖 Generated with Claude Code