Enhance CMake portability#810
Draft
benjaminmcq wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Benjamin Lee McQueen <mcq@disroot.org>
Spartan322
reviewed
Jul 23, 2026
Spartan322
reviewed
Jul 23, 2026
| link_libraries(${ICONV_LIBRARY}) | ||
| endif() | ||
|
|
||
| add_subdirectory(deps) |
Member
There was a problem hiding this comment.
Why was deps moved down here?
Author
There was a problem hiding this comment.
so the makefile it's jumping to knows about iconv
Co-authored-by: George L. Albany <Megacake1234@gmail.com>
Spartan322
reviewed
Jul 23, 2026
| ) | ||
|
|
||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| # all unix non apple systems need tbb this way |
Member
There was a problem hiding this comment.
Please follow the style FakeByte used for comments to keep consistency.
Spartan322
reviewed
Jul 23, 2026
Comment on lines
+96
to
+97
| # if needed detect other platforms | ||
|
|
Member
There was a problem hiding this comment.
Please follow the style FakeByte used for comments to keep consistency. Also remove the newline spacing.
Member
|
Also please change the commit message and PR to be specific about what this is doing, PRs and commit messages should describe what/why they're doing something, that's the style your commits should be doing, in this case it should say something like "Add unofficial BSD platform support" or something. |
Spartan322
added
enhancement
Spartan322
marked this pull request as draft
July 23, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR makes it so that we link TBB if(UNIX AND NOT APPLE) instead of Linux for portability and semantic reasons.
it also adds BSD as a preset which is bsd-x64
unsure if i should make changes in the README because of "official support," but if it's needed it can probably be included when the README is updated or as a standalone fix.