Skip to content

Refactor StringUtils as core/string headers#676

Merged
Spartan322 merged 1 commit into
masterfrom
refactor/core-string-util
Dec 5, 2025
Merged

Refactor StringUtils as core/string headers#676
Spartan322 merged 1 commit into
masterfrom
refactor/core-string-util

Conversation

@Spartan322

@Spartan322 Spartan322 commented Nov 29, 2025

Copy link
Copy Markdown
Member

Rename case-relevant utility functions to reflect ascii-only behavior
Prefer use of string_view for Utility.hpp functions
Change main.cpp's print_help to use std::string_view for program_name argument

@Spartan322 Spartan322 added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module labels Nov 29, 2025
Comment thread src/openvic-simulation/core/string/Utility.hpp
@Spartan322
Spartan322 force-pushed the refactor/core-string-util branch 3 times, most recently from 5f37ff1 to 8083cbc Compare November 30, 2025 22:53
Comment thread src/openvic-simulation/core/string/Utility.hpp Outdated
Comment thread src/openvic-simulation/core/string/Utility.hpp Outdated
@Spartan322
Spartan322 force-pushed the refactor/core-string-util branch 4 times, most recently from c081b72 to 05cf986 Compare December 5, 2025 01:28
Comment thread src/headless/main.cpp Outdated
Rename case-relevant utility functions to reflect ascii-only behavior
Prefer use of string_view for Utility.hpp functions
Change main.cpp's print_help to use std::string_view for program_name argument
@Spartan322
Spartan322 force-pushed the refactor/core-string-util branch from 05cf986 to 3eff950 Compare December 5, 2025 03:21

@BrickPi BrickPi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Spartan322
Spartan322 merged commit 55c064f into master Dec 5, 2025
16 checks passed
@Spartan322
Spartan322 deleted the refactor/core-string-util branch December 5, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants