Refactor BMP files to core/io path#668
Merged
Merged
Conversation
Spartan322
added
enhancement
wvpm
reviewed
Nov 26, 2025
wvpm
previously approved these changes
Nov 26, 2025
wvpm
left a comment
wvpm
left a comment
Contributor
There was a problem hiding this comment.
Looks good besides the weird ternary operator formatting.
Spartan322
force-pushed
the
refactor/core-io
branch
2 times, most recently
from
November 26, 2025 20:51
62217b6 to
6052647
Compare
Spartan322
force-pushed
the
refactor/core-io
branch
from
November 26, 2025 20:56
6052647 to
ff336e2
Compare
wvpm
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental refactor to achieve #625