Repository navigation
Conversation
CONVENTIONAL_COMMITS.md still described the 0.x series: it stated major_version_zero = true and that a breaking change bumps the minor version. pyproject.toml sets major_version_zero = false and the contributing guide documents a major bump, so the two guides disagreed. The bump table, the note and the examples now use 1.x versions. The scope list drops `temporal` and `utils`, which name code that no longer exists, and adds the scopes used in recent history (placement, cross-fitting, search, serialization, logging).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONVENTIONAL_COMMITS.mdstill described the 0.x series: it statedmajor_version_zero = trueand that a breaking change bumps the minor version.pyproject.tomlsetsmajor_version_zero = falseand the contributing guide documents a major bump, so the two guides disagreed.temporalandutils, which name code that no longer exists, and adds scopes used in recent history (placement,cross-fitting,search,serialization,logging).Docs-only change. I am happy to drop the scope-list part if you prefer to keep that list as it is.
Validation
Checks: full suite (2544 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.