Repository navigation
Conversation
RepresentationSearchCV only met an invalid candidate inside its first fold, so three mistakes surfaced late or with a misleading error: - methods="bspline" was iterated letter by letter and failed as the unknown method 'b'; - a misspelled entry raised only after every candidate listed before it had been cross-validated; - numerical_method in preprocessor_params collided with the searched method in a bare TypeError from Preprocessor(). fit now checks the candidates first and raises InvalidParamError naming the parameter. Names resolve as in Preprocessor(numerical_method=...), so aliases and None stay valid.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RepresentationSearchCVonly met an invalid candidate inside its first fold:methods="bspline"was iterated letter by letter and failed as the unknown method'b';numerical_methodinpreprocessor_paramscollided with the searched method in a bareTypeErrorfromPreprocessor().Fix
fitchecks the candidates first and raisesInvalidParamErrornaming the parameter. Names resolve through the registry as inPreprocessor(numerical_method=...), so aliases,Noneand registered representations stay valid.Tests and docs
Tests in
tests/compose/test_search.py, including one asserting that no estimator is fitted before the error; the class /fitdocstrings andtarget_awareness.mdare updated.Validation
Checks: full suite (2551 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.