Repository navigation
Conversation
set_verbosity() mapped any level outside 0-3 to INFO. A level above 3 therefore logged less than 3, and a negative level more than 0: Preprocessor(verbose=4) printed only the fit summary and dropped the per-feature table and the fitted decisions that verbose=2 and 3 log. The level is now clamped into 0-3, so verbosity never decreases as the level grows. This also applies to configure_logging() and to the Preprocessor's verbose parameter, which both go through set_verbosity().
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
set_verbosity()mapped any level outside 0-3 toINFO, so verbosity was not monotonic:Preprocessor(verbose=4)printed only the fit summary and dropped the per-feature table and the fitted decisions thatverbose=2/3log, andset_verbosity(-1)was louder than0.Fix
The level is clamped into 0-3. This also covers
configure_logging()and thePreprocessorverboseparameter, which both go throughset_verbosity().Tests and docs
Tests in
tests/integration/test_verbosity.py(clamping,configure_logging,verbose=4logs exactly whatverbose=3logs); docstrings and the fit-time logging section ofoutputs_and_inspection.mdare updated.Validation
Checks: full suite (2553 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.