Repository navigation
Conversation
Preprocessor.fit on a frame, array or dict with columns but no rows failed with a bare ZeroDivisionError: column-type detection divides the number of unique values by the row count for the cat_cutoff ratio. detect_column_types now raises EmptyDataError (a PretabDataError and a ValueError, scikit-learn's convention for empty training data) that names the estimator and the input shape. Input without columns keeps fitting to an empty output, as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Preprocessor.fiton input with columns but no rows failed with a bareZeroDivisionError: column-type detection divides the number of unique values by the row count for thecat_cutoffratio.Fix
detect_column_typesraisesEmptyDataError(already exported; aPretabDataErrorand aValueError, scikit-learn's convention for empty training data) naming the estimator and the input shape. Input without columns keeps fitting to an empty output.Tests and docs
Unit tests in
tests/compose/test_feature_detection.py, end-to-end tests for DataFrame / ndarray / dict intests/regression/test_edge_cases.py; thefitdocstring and the edge-case list inchoosing_a_method.mdare updated.Validation
Checks: full suite (2554 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.