Repository navigation
fix(distributions): name get_distribution in unknown-family error - #628
Merged
mkumar73 merged 2 commits intoNov 14, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mkumar73
approved these changes
Nov 14, 2026
mkumar73
left a comment
Collaborator
There was a problem hiding this comment.
- Error message now correctly identifies the shared distribution lookup, with regression coverage.
- All checks pass.
- PR approved
thank you for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an unknown
family, every LSS model raises an error that starts with "MambularLSS / LSS model.family". I got this with MLPLSS, so the message names a model I did not use. The reason is that the label is hard-coded inget_distribution().So this PR changes the label to "get_distribution", the function that checks the argument. That way the message is right for every caller.
unregister_optimizer()andunregister_scheduler()already do the same for their own arguments.I also changed the existing test for an unknown family, so it now checks the message too. With the code from main it fails.
just test: 3355 passedjust checkpasses