Skip to content

Fix Xcode 26 support regression#783

Merged
Kyle-Ye merged 1 commit intomainfrom
k-branch-1
Feb 8, 2026
Merged

Fix Xcode 26 support regression#783
Kyle-Ye merged 1 commit intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Feb 8, 2026

Close #773

@github-actions github-actions bot added bug Something isn't working build issue platform: iOS platform: macOS P1 Medium priority labels Feb 8, 2026
@Kyle-Ye Kyle-Ye merged commit ba930d8 into main Feb 8, 2026
4 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch February 8, 2026 13:12
@augmentcode
Copy link

augmentcode bot commented Feb 8, 2026

🤖 Augment PR Summary

Summary: Adds a conditional NSStringDrawingOptions shim entry for Xcode 26 / OS 26 SDKs to match updated UIFoundation headers.
Why: Prevents build regressions when compiling against newer SDKs where this enum case exists.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

NSStringDrawingUsesDeviceMetrics = 1 << 3, // Uses image glyph bounds instead of typographic bounds
NSStringDrawingTruncatesLastVisibleLine API_AVAILABLE(macos(10.5), ios(6.0), tvos(9.0), watchos(2.0), visionos(1.0)) = 1 << 5, // Truncates and adds the ellipsis character to the last visible line if the text doesn't fit into the bounds specified. Ignored if NSStringDrawingUsesLineFragmentOrigin is not also set.
// Check if Xcode 26.0 related platform SDKs are available
#if (defined(__IPHONE_26_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_26_0) || \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This #if guard checks iOS/macOS/tvOS/watchOS SDK macros, but the new option is also marked API_AVAILABLE(..., visionos(26.0)). If visionOS SDKs gate availability via vision-specific macros (e.g. __VISION*_VERSION_MAX_ALLOWED), consider including that here so the shim stays in sync when building for visionOS.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.13%. Comparing base (560ced4) to head (2e981d4).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (560ced4) and HEAD (2e981d4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (560ced4) HEAD (2e981d4)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #783       +/-   ##
===========================================
- Coverage   26.20%   13.13%   -13.07%     
===========================================
  Files         650      620       -30     
  Lines       40232    36773     -3459     
===========================================
- Hits        10543     4831     -5712     
- Misses      29689    31942     +2253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build issue P1 Medium priority platform: iOS platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix Xcode 26 SDK build issue for NSStringDrawingOptions

1 participant