Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Feb 8, 2026

Summary

  • Revert PRODUCT_NAME to $(TARGET_NAME) to fix product reference naming
  • Workaround ClipEffectUITests snapshot precision issues with reduced perceptualPrecision
  • Disable safeAreaPaddingWithEdgeInsets test due to extra spacing value issue (Reopen Bug: safeAreaPadding API not working correctly #511 to track it)

@github-actions github-actions bot added bug Something isn't working test Test related issue build issue labels Feb 8, 2026
@augmentcode
Copy link

augmentcode bot commented Feb 8, 2026

🤖 Augment PR Summary

Summary: This PR fixes build/test naming issues and stabilizes UI snapshot tests.

Changes:

  • Reverts PRODUCT_NAME to $(TARGET_NAME) to restore expected product naming.
  • Updates Example.xcodeproj product references to match the new *.app/*.xctest output names.
  • Disables the safeAreaPaddingWithEdgeInsets snapshot test due to an extra spacing-value issue.
  • Adjusts ClipEffectUITests snapshot tolerances via reduced perceptualPrecision and documents the intent with a FIXME.

Technical Notes: The snapshot changes aim to reduce false failures from minor rendering diffs while the underlying precision differences are investigated.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.20%. Comparing base (560ced4) to head (3847755).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   26.20%   26.20%   -0.01%     
==========================================
  Files         650      650              
  Lines       40232    40232              
==========================================
- Hits        10543    10542       -1     
- Misses      29689    29690       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 1ff649d into main Feb 8, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the fix/test branch February 8, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build issue platform: macOS test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant