Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 20, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 20, 2026

🤖 Augment PR Summary

Summary: Updates the Transition API surface and implementations to align with the audited SwiftUI 6.5.4 behavior.

Changes:

  • Adds new transition implementations: AsymmetricTransition, CombiningTransition, FilteredTransition, ModifierTransition, and PushTransition.
  • Introduces new convenience APIs on AnyTransition/Transition: asymmetric, combined, animation, modifier, and push(from:).
  • Adds OffsetTransition and wires it to AnyTransition.offset(...)/Transition.offset(...).
  • Extends _OffsetEffect with protobuf encode/decode support.
  • Makes Edge.translationOffset(for:) available outside MoveTransition’s file for reuse (e.g. push transitions).
  • Simplifies Transition helpers that extract hasContentTransition and contentTransitionEffects results.
  • Moves OpacityEffect.swift under Render/RendererEffect (rename-only change).

Technical Notes: Composite transitions now participate in content transitions by emitting ContentTransition.Effect arrays, including insertion/removal event tagging where appropriate (e.g. asymmetric + push).

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 194 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.84%. Comparing base (d1e8132) to head (697c240).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...re/Animation/Transition/AsymmetricTransition.swift 0.00% 52 Missing ⚠️
...iftUICore/Render/GeometryEffect/OffsetEffect.swift 0.00% 39 Missing ⚠️
...ftUICore/Animation/Transition/PushTransition.swift 0.00% 34 Missing ⚠️
...ore/Animation/Transition/CombiningTransition.swift 0.00% 30 Missing ⚠️
...Core/Animation/Transition/FilteredTransition.swift 0.00% 25 Missing ⚠️
...Core/Animation/Transition/ModifierTransition.swift 0.00% 7 Missing ⚠️
...nSwiftUICore/Animation/Transition/Transition.swift 0.00% 6 Missing ⚠️
...ftUICore/Animation/Transition/MoveTransition.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   13.90%   13.84%   -0.07%     
==========================================
  Files         579      584       +5     
  Lines       34565    34741     +176     
==========================================
+ Hits         4806     4809       +3     
- Misses      29759    29932     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/asymmetric branch from 96a269c to 697c240 Compare January 20, 2026 19:08
@Kyle-Ye Kyle-Ye merged commit 175b6c8 into main Jan 20, 2026
@Kyle-Ye Kyle-Ye deleted the feature/asymmetric branch January 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants