Remove the stray [tool.pytest] section from pyproject.toml - #13
Open
djGLiTCH wants to merge 1 commit into
Open
Conversation
pytest only reads [tool.pytest.ini_options] from pyproject.toml, so the [tool.pytest] block above it does nothing. Its python_files patterns have never applied, and collection has always used pytest's defaults. Every test file here is named test_*.py, which those defaults already match, so nothing relied on it. pytest 9 turns the duplicate into a hard error and refuses to start. The pinned pytest==8.3.4 in requirements-dev.txt keeps the suite working for now, but anyone testing against a newer pytest locally hits it today, and it will need to be removed if the project decides to upgrade past 9.0. Dropping the dead block changes nothing that runs today: the suite gives 10 failed, 83 passed before and after on 8.3.4, and the same on 9.1.1, which could not start at all before. Those 10 failures already existed. Signed-off-by: Jacob Simpson <28767380+djGLiTCH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomlcarries both[tool.pytest]and[tool.pytest.ini_options].pytest only reads the latter from
pyproject.toml, so the former does nothing -its
python_filespatterns have never applied and collection has always usedthe defaults. Every test file is named
test_*.py, which those defaults alreadymatch, so nothing relied on it and it can go rather than being migrated across.
pytest 9 turns the duplicate into a hard error and refuses to start. The pinned
pytest==8.3.4inrequirements-dev.txtkeeps the suite working for now, butanyone testing against a newer pytest locally hits it today, and the block will
need to be removed if the project decides to upgrade past 9.0.
Those 10 failures already existed.