Skip to content

feat: add sponsor_id filter to getAllMyBadgeScans endpoint#528

Merged
smarcet merged 1 commit into
mainfrom
feature/get-my-badge-scans-sponsor-id-filter
Apr 15, 2026
Merged

feat: add sponsor_id filter to getAllMyBadgeScans endpoint#528
smarcet merged 1 commit into
mainfrom
feature/get-my-badge-scans-sponsor-id-filter

Conversation

@romanetar
Copy link
Copy Markdown
Collaborator

@romanetar romanetar commented Apr 14, 2026

ref https://app.clickup.com/t/86b94hwxj

Summary by CodeRabbit

  • New Features
    • Added sponsor-based filtering capability to the badge-scan listing API, allowing badge scans to be filtered by sponsor identifier.

Signed-off-by: romanetar <roman_ag@hotmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 208dbedc-0c12-4e88-b9ba-e8c18a1ea137

📥 Commits

Reviewing files that changed from the base of the PR and between 6439c0a and 65818de.

📒 Files selected for processing (1)
  • app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeScanApiController.php

📝 Walkthrough

Walkthrough

Added sponsor_id as a supported filter field in the badge-scan API listing endpoint. The field is registered in both the equality-filterable fields configuration and validation rules as an optional integer parameter.

Changes

Cohort / File(s) Summary
Badge Scan API Filter Configuration
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeScanApiController.php
Added sponsor_id field to equality-filterable fields and validation rules for the getAllMyBadgeScans endpoint (+2 lines).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A sponsor's ID now filters with grace,
Two little lines in their rightful place,
Badge scans aligned by patron's name,
The API's flexibility grows just the same! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a sponsor_id filter to the getAllMyBadgeScans endpoint, which matches the changeset content.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/get-my-badge-scans-sponsor-id-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@romanetar romanetar requested a review from smarcet April 14, 2026 14:17
@github-actions
Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-528/

This page is automatically updated on each push to this PR.

Copy link
Copy Markdown
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit b535f89 into main Apr 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants