Skip to content

fix: improve SnackbarNotification cleanup #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priscila-moneo wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix: improve SnackbarNotification cleanup #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/mui/SnackbarNotification/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,21 @@ const SnackbarNotification = ({
const messageContext = useMemo(() => ({ successMessage, errorMessage }), []);

const clearMessage = () => {
setMsgData({});
clearSnackbarMessage();
setMsgData({});
};

const onClose = () => {
setOpen(false);
setTimeout(clearMessage, NOTIFICATION_TIMEOUT);
Copy link
Copy Markdown
Collaborator

@smarcet smarcet May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priscila-moneo could u explain the rationale of this on the PR description ?

Copy link
Copy Markdown
Contributor Author

@priscila-moneo priscila-moneo May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarcet updated!

};

const handleExited = () => {
clearMessage();
};

useEffect(() => {
if (!empty(msgData.html)) {
setOpen(true);
} else {
setOpen(false);
}
}, [msgData]);

Expand All @@ -71,6 +72,7 @@ const SnackbarNotification = ({
<Snackbar
open={open}
onClose={onClose}
onExited={handleExited}
anchorOrigin={{ vertical: "top", horizontal: "center" }}
autoHideDuration={NOTIFICATION_TIMEOUT}
>
Expand Down
Loading