Skip to content

Add migrations to fix broken relations before rel-db#3283

Merged
hjanott merged 9 commits intoOpenSlides:pre-4.3.0-migrationsfrom
hjanott:migration_image
Feb 2, 2026
Merged

Add migrations to fix broken relations before rel-db#3283
hjanott merged 9 commits intoOpenSlides:pre-4.3.0-migrationsfrom
hjanott:migration_image

Conversation

@hjanott
Copy link
Copy Markdown
Member

@hjanott hjanott commented Jan 22, 2026

No description provided.

@hjanott hjanott added the migration Introduces a new migration label Jan 22, 2026
@hjanott
Copy link
Copy Markdown
Member Author

hjanott commented Jan 23, 2026

That will not be necessary since this migration is just meant as a preparation of migration 100. That itself will not keep any of the projection relations as they are 1:n-relations with the 1-side on the projection.

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Jan 23, 2026
@luisa-beerboom
Copy link
Copy Markdown
Member

That will not be necessary since this migration is just meant as a preparation of migration 100. That itself will not keep any of the projection relations as they are 1:n-relations with the 1-side on the projection.

If that's so I guess it's fine

@rrenkert rrenkert changed the base branch from main to pre-4.3.0-migrations January 23, 2026 16:01
@hjanott hjanott assigned peb-adr and luisa-beerboom and unassigned hjanott and m-schieder Jan 23, 2026
@hjanott hjanott removed the request for review from m-schieder January 23, 2026 16:22
@hjanott hjanott requested a review from peb-adr January 23, 2026 16:22
Comment thread tests/system/migrations/test_0076_projector_scroll_minimum.py
@luisa-beerboom
Copy link
Copy Markdown
Member

I added migration 0077. I didn't touch my change request for 0067 though.

events: list[BaseRequestEvent] = []
for id_, data in all_existing_groups.items():
if remove_meeting_user_ids := set(
data.get("meeting_user_ids", [])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get(...)'s return value can be None.
I quickfixed it locally by adding get(...) or [].

Please fix in your preferred way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@luisa-beerboom luisa-beerboom removed their assignment Jan 27, 2026
Copy link
Copy Markdown
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the 76 tests myself. They're okay now in my book.

Everything after 76 is my work, so I'm taking the liberty of assigning @vkrasnovyd to review that.

@vkrasnovyd vkrasnovyd removed their assignment Jan 30, 2026
@hjanott hjanott merged commit 9a4d2a0 into OpenSlides:pre-4.3.0-migrations Feb 2, 2026
2 checks passed
peb-adr pushed a commit that referenced this pull request Mar 18, 2026
* add migration 75 through 78

---------

Co-authored-by: Luisa <luisa.beerboom@intevation.de>
peb-adr pushed a commit that referenced this pull request Mar 19, 2026
* add migration 75 through 78

---------

Co-authored-by: Luisa <luisa.beerboom@intevation.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration Introduces a new migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants