refactor: Replace Arduino Serial with esp native#317
Conversation
|
hhvrc
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #include <cstdio> | ||
|
|
||
| #define SERPR_SYS(format, ...) ::Serial.printf("$SYS$|" format "\r\n", ##__VA_ARGS__) | ||
| #define SERPR_SYS(format, ...) printf("$SYS$|" format "\r\n", ##__VA_ARGS__) | ||
| #define SERPR_RESPONSE(format, ...) SERPR_SYS("Response|" format, ##__VA_ARGS__) |
There was a problem hiding this comment.
Switching common.h to include <cstdio> drops the only Arduino header that pulled in the HardwareSerial Serial declaration used throughout SerialInputHandler.cpp (e.g., _skipSerialWhitespaces still calls ::Serial.available()/read()). With no remaining include providing Serial, the file now fails to compile with ‘Serial’ was not declared in this scope.
Useful? React with 👍 / 👎.
hhvrc
changed the title
Cpp-Linter Report
|
1 participant
No description provided.