Skip to content

Add null check for ns_uri in cpe_dict_detect_version_priv #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-cerny merged 1 commit into from
Mar 26, 2026
+7 −3
Merged

Add null check for ns_uri in cpe_dict_detect_version_priv #2324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/CPE/cpedict.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*
* Authors:
Expand Down Expand Up @@ -165,7 +165,7 @@ bool cpe_item_is_applicable(struct cpe_item* item, cpe_check_fn cb, void* usr)
return ret;
}

const char * cpe_dict_model_supported(void)
const char * cpe_dict_model_supported(void)
{
return CPE_DICT_SUPPORTED;
}
Expand All @@ -183,6 +183,10 @@ char *cpe_dict_detect_version_priv(xmlTextReader *reader)
return NULL;
}
const char* ns_uri = (const char *) xmlTextReaderConstNamespaceUri(reader);
if (ns_uri == NULL) {
oscap_seterr(OSCAP_EFAMILY_OSCAP, "Expected namespace uri for cpe-list, found none.");
return NULL;
}

/* find generator */
while (xmlTextReaderRead(reader) == 1
Expand Down
Loading