Add OpenSSL 4.x support and switch to provider-only mode#634
Merged
mtrojnar merged 6 commits intoOpenSC:masterfrom Feb 1, 2026
Merged
Add OpenSSL 4.x support and switch to provider-only mode#634mtrojnar merged 6 commits intoOpenSC:masterfrom
mtrojnar merged 6 commits intoOpenSC:masterfrom
Conversation
Member
|
I think returning 0 (success) in tests that are never supposed to be executed could be confusing. Should we return something else, such as 1 or 77, just in case someone decides to execute this code anyway? Printing an error message would be a good idea as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: #631
Current Behavior
libp11 does not build correctly with OpenSSL 4.x.
New Behavior
libp11 builds cleanly with OpenSSL 4.x
Scope of Changes
Testing
Tested with OpenSSL 3.x (all tests passing).
Some OpenSSL 4.0.0-dev test failures are expected at this stage and will be handled in subsequent PRs.
Additional Notes
Behavior for OpenSSL ≤ 3.x is preserved.
In OpenSSL 4.x, the
OPENSSL_NO_ENGINEmacro is always defined. ENGINE-based code paths are therefore intentionally disabled.License Declaration