start-stop-daemon: support cpu scheduler env variable#693
Open
Forza-tng wants to merge 2 commits intoOpenRC:masterfrom
Open
start-stop-daemon: support cpu scheduler env variable#693Forza-tng wants to merge 2 commits intoOpenRC:masterfrom
Forza-tng wants to merge 2 commits intoOpenRC:masterfrom
Conversation
Introduced `SSD_CPUSCHEDULER` and `SSD_CPUSCHEDULER_PRIO` environment variables to complement the `--scheduler` command line argument.
Introduced `SSD_CPUSCHEDULER` and `SSD_CPUSCHEDULER_PRIO` environment variables to complement the `--scheduler` command line argument.
N-R-K
suggested changes
Mar 18, 2025
|
|
||
| // Handle SSD_CPUSCHEDULER for scheduler type | ||
| if ((tmp = getenv("SSD_CPUSCHEDULER"))) { | ||
| scheduler = strdup(tmp); |
Contributor
There was a problem hiding this comment.
The implementation of getenv() is not required to be reentrant. The string pointed to by the return value of getenv() may be statically allocated,
and can be modified by a subsequent call to getenv(), putenv(3), setenv(3), or unsetenv(3).
Okay, I see.
| .Va SSD_CPUSCHEDULER_PRIO | ||
| can also set the CPU scheduling priority of the daemon, but the command line | ||
| option takes precedence. | ||
| .Pp |
Contributor
There was a problem hiding this comment.
Also should be added to supervise-deamon for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced
SSD_CPUSCHEDULERandSSD_CPUSCHEDULER_PRIOenvironment variables to complement the--schedulercommand line argument.Closes #657