scheduler: Sanitize values for FilterNice directive#1511
Open
zdohnal wants to merge 1 commit intoOpenPrinting:masterfrom
Open
scheduler: Sanitize values for FilterNice directive#1511zdohnal wants to merge 1 commit intoOpenPrinting:masterfrom
zdohnal wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
mosvald
reviewed
Mar 16, 2026
We allow only values 0-19 for `nice()` in cupsd, but when reading the configuration this fact was not applied.
michaelrsweet
requested changes
Mar 16, 2026
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
See comments.
I'm somewhat ambivalent about adding a new type just for this one (rarely-used) directive; ideally the cupsd_var_t structure could be extended to include lower and upper range values, or you could just move the "FilterNice" processing to the read_cupsd_conf function.
|
|
||
| while (*value) | ||
| { | ||
| if (!isdigit(*value++)) |
Member
There was a problem hiding this comment.
This will increment the value pointer past the digits, then you call strtol which won't see any value and you'll just get 0.
Better to simply call strtol with an end pointer and check the range and any remaining characters. Also make sure the use long for the value...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow only values 0-19 for
nice()in cupsd, but when reading the configuration this fact was not applied.