Integrate Clang AddressSanitizer in tests #1903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3manifold
force-pushed
the
asan
branch
6 times, most recently
from
39b44c1 to
efc5ee8
Compare
3manifold
force-pushed
the
asan
branch
3 times, most recently
from
5659d05 to
0efd96b
Compare
3manifold
changed the title
3manifold
changed the title
3manifold
commented
Jul 18, 2025
.github/workflows/ci.yml
Outdated
| - name: Test ASAN | ||
| if: matrix.backend == 'asan' | ||
| run: | | ||
| ASAN_OPTIONS=detect_leaks=1:print_stats=1 tests/ctranslate2_test tests/data |
Author
There was a problem hiding this comment.
Force ASAN_OPTIONS=detect_leaks=1 in case os: [ubuntu-22.04] matrix expands in the future (leak detection is turned on by default on Linux).
3manifold
commented
Jul 18, 2025
Collaborator
|
For context: |
Author
Thanks for the note. Worth noting that sanitisers still exist but are maintained under the LLVM project (link). |
3manifold
changed the title
3manifold
force-pushed
the
asan
branch
2 times, most recently
from
5b85a40 to
43743ae
Compare
jordimas
reviewed
Dec 23, 2025
| build-and-test-cpp-x86_64-sanitizers: | ||
| runs-on: ${{ matrix.os }} | ||
| env: |
Collaborator
There was a problem hiding this comment.
My take is that we will run this only in Linux. If this is the case we should consider removing the matrix execution to simplify the job. Same for the backends.
jordimas
reviewed
Dec 23, 2025
| tests/ctranslate2_test tests/data | ||
| build-and-test-cpp-x86_64-sanitizers: | ||
| runs-on: ${{ matrix.os }} |
Collaborator
There was a problem hiding this comment.
My understanding is that we only use a sanitizer, consider if "build-and-test-cpp-x86_64-sanitizer" makes more sense.
jordimas
reviewed
Dec 23, 2025
| option(WITH_TENSOR_PARALLEL "Compile with NCCL and MPI backend" OFF) | ||
| option(WITH_FLASH_ATTN "Compile with Flash Attention 2" OFF) | ||
| option(GOOGLE_ADDRESS_SANITIZER "ASAN" OFF) | ||
|
|
Collaborator
There was a problem hiding this comment.
Two suggestions:
- ENABLE_ADDRESS_SANITIZER may be a better name than GOOGLE_ADDRESS_SANITIZER because it is not Google specific (you also changed the name of the PR).
- Consider a better description for the switch like "Enable AddressSanitizer for memory error detection"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: temporarily introduced a memory leak in an operator to check that
asanworks:https://github.com/OpenNMT/CTranslate2/actions/runs/16419223767/job/46392885237#logs
resolves #1928