Skip to content

fix(device): toast when opening a device fails to list devices #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snekxs merged 1 commit into from
Sep 30, 2026
Merged

fix(device): toast when opening a device fails to list devices #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/device/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2021,9 +2021,20 @@ async function waitForControllerIdle(): Promise<void> {
}
}

/** A wedged OpenMouse Bridge rejects getDevices(); toast it instead of failing silently. */
async function authorizedDeviceGroups(): Promise<HIDDevice[][] | null> {
try {
return logicalDeviceGroups(await navigator.hid?.getDevices() ?? []);
} catch (error) {
toastForError("Connection failed", error);
return null;
}
}

export async function selectAuthorizedDevice(index: number): Promise<void> {
await waitForControllerIdle();
const groups = logicalDeviceGroups(await navigator.hid?.getDevices() ?? []);
const groups = await authorizedDeviceGroups();
if (!groups) return;
const group = groups[index];
if (!group) return;
if (group.some((device) => device === activeDevice) && latestDeviceStatus !== null) return;
Expand Down Expand Up @@ -2057,7 +2068,8 @@ export async function selectAuthorizedDevice(index: number): Promise<void> {
/** Open the given device's dashboard from the picker, connecting it first when needed. */
export async function openDeviceOverview(index: number): Promise<void> {
await waitForControllerIdle();
const groups = logicalDeviceGroups(await navigator.hid?.getDevices() ?? []);
const groups = await authorizedDeviceGroups();
if (!groups) return;
const group = groups[index];
if (!group) {
await connect();
Expand Down
Loading