feat: bring back the dongle LED toggle as an Advanced card - #376
Merged
snekxs merged 1 commit intoSep 29, 2026
Merged
Conversation
The receiver LED button lived on the old connection card and was lost in d761e60, leaving toggleDongleLed() with no UI. A small WIRELESS card now shows whenever the driver reports a boolean dongleLedEnabled, which is what the old Pulsar-only gate amounted to, and toggleDongleLed() accepts any client with setDongleLed() so the Attack Shark R5 Ultra receiver (mouse-protocol#141) can use it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support ticket #125: the user turned their Attack Shark R5 Ultra's dongle LED off with old Attack Shark software that later dropped the option, and can't turn it back on. The protocol side is OpenMouse-Project/mouse-protocol#141.
Why a new card
The receiver LED button used to live on the old connection card (
supportsDongleLed, Pulsar only) and was lost in d761e60. Since thentoggleDongleLed()has had no UI, so Pulsar receivers that reportdongleLedEnabledhad no way to switch it.Change
DongleLedCard(Advanced tab, WIRELESS): heading plus a switch, same layout as the auto-sleep card.cardAvailability().dongleLed:typeof status.dongleLedEnabled === "boolean". The Pulsar driver setsbrand: "Pulsar"and only reports a boolean for receivers it can read, so this matches the old gate for Pulsar. Pulsar Pro reports nothing and stays hidden.toggleDongleLed()checks for any active client withsetDongleLed(), not only Pulsar clients.attack-sharkpreview fixture reportsdongleLedEnabled: false.Checks
npm run buildandnpm test(240/240) pass.tscis also clean against the local mouse-protocol#141 branch.?preview=attack-sharkshows the card (off),?preview=pulsarshows it again (on),?preview=crdrakohas no card.Follow-up
The R5 Ultra only gets the card after mouse-protocol#141 is released and
@openmouse/protocolis bumped here. Pulsar gets it back as soon as this merges.