fix(logitech): address a long-only HID++ collection on long reports - #155
Merged
snekxs merged 1 commit intoOct 3, 2026
Merged
Conversation
Chrome on some platforms hands out one HIDDevice per top-level collection, so a Lightspeed receiver can arrive as its usage-2 (report 0x11) half alone. Every short-report probe on it was rejected by the host before reaching the receiver, classifyHidpp20Probe counted that rejection as a HID++ 2.0 answer without a sensor, and a PRO X Superlight receiver came back "Not a mouse" (ticket 0143). - requestWithOptions sends long reports when the report device has no short collection, the same path Bluetooth already takes. - classifyHidpp20Probe returns "unreachable" for anything that is not a HID++ reply, and the index probe rethrows it instead of inventing an answer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discord ticket 0143: a G PRO X Superlight on its Lightspeed receiver ("USB Receiver", 0xc547) is refused with Not a mouse even though the receiver is the right pick. Windows, Opera, through the Bridge, G HUB uninstalled.
The reporter's diagnostics list the receiver's collections as
0x000C:0x0001, 0x0001:0x0080, 0x0001:0x0006, 0x0001:0x0002, 0xFF00:0x0002: the long HID++ collection (report 0x11) and no short one. The driver probed every device index with short reports, the host rejected eachsendReport(0x10)before it reached the receiver, andclassifyHidpp20Probecounted that rejection as a HID++ 2.0 answer with no sensor behind it. Seven "answers", no DPI feature,NotAMouseError.requestWithOptionsnow sends long reports when the report device has no short collection, the same path Bluetooth already takes. Devices that declare the short collection are unchanged.classifyHidpp20Probereturns"unreachable"for anything that is not a HID++ reply, and the index probe rethrows it so the real transport error reaches the user instead of a wrong "not a mouse".Test plan
npm test(1973 pass)sendReportis not reported asNotAMouseError