Skip to content

Land X11 DPI routing, already-running panel, and protocol v0.42.1 - #22

Merged
snekxs merged 4 commits into
mainfrom
fix/x11-dpi-panel-and-protocol
Oct 13, 2026
Merged

snekxs merged 4 commits into
mainfrom
fix/x11-dpi-panel-and-protocol

Conversation

@snekxs

@snekxs snekxs commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Route Attack Shark X11 DPI through AttackSharkHidClient while leaving polling-only requests on the verified feature-report path.
  • Ask a running Bridge to open its tray panel when a second launch finds port 17846 already bound, and show that panel once on first launch.
  • Bump @openmouse/protocol from v0.30.0 to v0.42.1, the current mouse-protocol release.

Test plan

  • Confirm the three required Check workflows pass
  • Second Bridge launch focuses the existing panel instead of exiting on a bind error
  • Attack Shark X11 DPI writes go through the six-stage table; polling-only writes stay on the direct report

Made with Cursor

Summary by CodeRabbit

  • New Features
    • DPI settings are now supported for Attack Shark X11 mice, alongside polling-rate controls.
    • Opening the app when it is already running brings up the existing window instead of starting another instance.
    • The app window and taskbar entry are shown on first launch.
  • Bug Fixes
    • Improved handling of app startup when another instance is already using the service.

snekxs and others added 3 commits October 13, 2026 15:38
…ck up protocol v0.30.0

Polling-only requests keep the verified direct feature-report path;
requests with DPI fall through to AttackSharkHidClient, which drives the
0x04 six-stage table for model 0x55 (mouse-protocol #174, issue #161).
Bump @openmouse/protocol v0.10.0 -> v0.30.0 so the rebuilt-config allowlist
includes the genuine X11.
A second launch died on port 17846 with nothing on screen, and process::exit dropped that error before the log flushed. Ask the running instance to show its panel, and show that panel once on first launch.

Co-authored-by: Cursor <cursoragent@cursor.com>
Bridge's native helper should track the current mouse-protocol release, which includes the X11 DPI driver and the DeathAdder polling commit.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added area: native Native bridge and platform services area: devices HID access and device drivers area: documentation Documentation area: dependencies Dependency manifests and lockfiles labels Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: OpenMouse-Project/OpenMouse-Bridge/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ca818cea-baa7-44c5-bf03-06f074ce75c9
📥 Commits

Reviewing files that changed from the base of the PR and between 8e9e1c8 and 47a230f.

⛔ Files ignored due to path filters: 1
  • native-hid/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 8
  • native-hid/README.md
  • native-hid/package.json
  • native-hid/src/apply.mjs
  • src/api.rs
  • src/config.rs
  • src/desktop.rs
  • src/main.rs
  • src/service.rs
 _____________________________________________
< My #FF570A highlighter marks all the TODOs. >
 ---------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Ubuntu CI runs cargo fmt --check, which failed on the split tracing::info call.

Co-authored-by: Cursor <cursoragent@cursor.com>
@snekxs
snekxs merged commit 6369d0b into main Oct 13, 2026
5 checks passed
@snekxs
snekxs deleted the fix/x11-dpi-panel-and-protocol branch October 13, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dependencies Dependency manifests and lockfiles area: devices HID access and device drivers area: documentation Documentation area: native Native bridge and platform services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant