Conversation
OpenModelica made the Rust simulation runtime the default for --simCodeTarget=C (OpenModelica/OpenModelica#16913) and removed C+Rust; --simCodeTarget=C.old now links the old libSimulationRuntimeC. The master job therefore tests what c-plus-rust did, and c-old keeps the old runtime covered, differing from master in the runtime alone. It is built like master: the old runtime is on by default (OM_OMC_ENABLE_C_OLD_RUNTIME), so no cmake flags are needed. Its results are a column of the default overview.html rather than a page of their own, and the --new-branch workaround for c-plus-rust is gone. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenModelica made the Rust simulation runtime the default for --simCodeTarget=C (OpenModelica/OpenModelica#16913) and removed C+Rust; --simCodeTarget=C.old now links the old libSimulationRuntimeC. The master job therefore tests what c-plus-rust did, and c-old keeps the old runtime covered, differing from master in the runtime alone.
It is built like master: the old runtime is on by default (OM_OMC_ENABLE_C_OLD_RUNTIME), so no cmake flags are needed. Its results are a column of the default overview.html rather than a page of their own, and the --new-branch workaround for c-plus-rust is gone.
Assisted-by: Claude Opus 5.5