Add version resolution for OMPython with tests and CI checks - #480
Merged
Merged
Conversation
Add OMPython._version to resolve the installed package version via importlib.metadata, falling back to reading pyproject.toml when running from an uninstalled source tree. Exposes __version__ and get_version(). Only install tomli on Python < 3.11, since tomllib is available in the standard library from 3.11 onward. Add unit tests covering both resolution paths: the installed-metadata path and the pyproject.toml fallback, including the case where both fail and resolution degrades to "unknown" instead of raising. Update CI workflow to print the resolved OMPython version, fail the build if it resolves to "unknown", and surface it via step output and job summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OMPython._version to resolve the installed package version via importlib.metadata, falling back to reading pyproject.toml when running from an uninstalled source tree. Exposes version and get_version().
Only install tomli on Python < 3.11, since tomllib is available in the standard library from 3.11 onward.
Add unit tests covering both resolution paths: the installed-metadata path and the pyproject.toml fallback, including the case where both fail and resolution degrades to "unknown" instead of raising.
Update CI workflow to print the resolved OMPython version, fail the build if it resolves to "unknown", and surface it via step output and job summary.