Skip to content

fix: log checkpoint and rolling-state load failures instead of printing #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VenishPaneliya wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −3
Open

fix: log checkpoint and rolling-state load failures instead of printing #9635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions syft/sync/connections/connection_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def get_latest_checkpoint(self) -> Checkpoint | None:
raw = self.peer_store.decrypt_and_verify_for_self_if_needed(raw)
return Checkpoint.from_compressed_data(raw)
except Exception as e:
print(f"Warning: Failed to load checkpoint: {e}")
logger.warning(f"Failed to load checkpoint: {e}")
return None

def get_events_count_since_checkpoint(
Expand Down Expand Up @@ -532,7 +532,7 @@ def get_all_incremental_checkpoints(self) -> List[IncrementalCheckpoint]:
cp = IncrementalCheckpoint.from_compressed_data(raw)
checkpoints.append(cp)
except Exception as e:
print(f"Warning: Failed to load incremental checkpoint: {e}")
logger.warning(f"Failed to load incremental checkpoint: {e}")
continue
return sorted(checkpoints, key=lambda c: c.sequence_number)

Expand Down Expand Up @@ -569,7 +569,7 @@ def get_rolling_state(self) -> RollingState | None:
raw = self.peer_store.decrypt_and_verify_for_self_if_needed(raw)
return RollingState.from_compressed_data(raw)
except Exception as e:
print(f"Warning: Failed to load rolling state: {e}")
logger.warning(f"Failed to load rolling state: {e}")
return None

def delete_rolling_state(self) -> None:
Expand Down
Loading